Experience from the Hargreaves-Samani Example
We found some inconvenient stuff while setting up the example. It would be nice to:
-
not require the _validate
method (when there is nothing to validate), see !156 (merged) -
not require the _finalize
method (when nothing needs to be finalized), see !156 (merged) -
have an attribute in the ConnectHelper
calledall_data_pulled
that basically replaces this line:all(data is not None for data in self.in_data.values())
-
maybe have a force_units
routine in the data tools that could help with empirical formulas, where some parameters simply don't have a unit -
we should setup a CI checking the examples with black
andisort
and maybepylint
-
be able to read static data from file (and have a single NetCDF Reader
andWriter
object) -
be able to mark inputs/outputs as static (for example with a special time value like fm.STATIC
)
What do you think @mlange ?
Edited by Martin Lange