mHM issueshttps://git.ufz.de/mhm/mhm/-/issues2024-02-26T09:47:50+01:00https://git.ufz.de/mhm/mhm/-/issues/254Doc: MacOS install instructions missing netcdf-fortran package2024-02-26T09:47:50+01:00Sebastian MüllerDoc: MacOS install instructions missing netcdf-fortran packageThere is a [new homebrew formula](https://github.com/Homebrew/homebrew-core/commit/6e5d43832dd8680fd58b292b0514bc150244be1c) for [netcdf-fortran](https://formulae.brew.sh/formula/netcdf-fortran).
Before, netcdf-fortran was part of the [...There is a [new homebrew formula](https://github.com/Homebrew/homebrew-core/commit/6e5d43832dd8680fd58b292b0514bc150244be1c) for [netcdf-fortran](https://formulae.brew.sh/formula/netcdf-fortran).
Before, netcdf-fortran was part of the [netcdf formula](https://github.com/Homebrew/homebrew-core/pull/112159).Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/240Hourly discharge simulations require that provided Qobs file starts at hour 0...2024-02-26T09:47:22+01:00Oldrich RakovecHourly discharge simulations require that provided Qobs file starts at hour 00 and end at hour 23To print out hourly discharge simulations, current implementation requires that provided Qobs file starts at hour 00 and end at hour 23,
otherwise, mHM provides only daily Qobs file without the `subdaily_discharge` output file.
We wil...To print out hourly discharge simulations, current implementation requires that provided Qobs file starts at hour 00 and end at hour 23,
otherwise, mHM provides only daily Qobs file without the `subdaily_discharge` output file.
We will provide with @shresthp test datawishlistSebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/235Theoretical documentation of mHM and its modules2024-02-26T09:47:05+01:00Pallav Kumar Shresthapallav-kumar.shrestha@ufz.deTheoretical documentation of mHM and its modulesIf I am not wrong, as of today, the mHM documentation [page](https://mhm.pages.ufz.de/mhm/latest/) has ample content that would comprise say the "user manual" but lacks the "theoretical documentation". The only exception is an awesomely ...If I am not wrong, as of today, the mHM documentation [page](https://mhm.pages.ufz.de/mhm/latest/) has ample content that would comprise say the "user manual" but lacks the "theoretical documentation". The only exception is an awesomely compiled [chapter on mRM](https://mhm.pages.ufz.de/mhm/latest/m_r_m.html).
This lack of easy access of theory behind mHM has been commented by many external users. The current two options modellers have are 1) to dive in the source code to get the information, or 2) read [Samaniego et al. 2010 WRR paper](https://agupubs.onlinelibrary.wiley.com/doi/full/10.1029/2008WR007327) where equations have been layed out but might not be best source to get hold of theory behind mHM on first try.
Questions and comments:
1. Would it make sense to compile chapters for different processes of mHM (snow, evaporation, etc.) like the one for mRM?
2. Who should compile the chapters? Perhaps the authors who are still active with us are the best fitted for this?
3. If this becomes a "multi-person" task, should there be a guideline/ general template that we follow, perhaps the mRM chapter. In my opinion this is important as the structure gives better readability? [This is a reference theoretical documentation](https://swat.tamu.edu/media/99192/swat2009-theory.pdf), which has this nice idea of tabulating the variables and parameters related to a process at end of each chapter.
I am pretty sure this will require some planning and time to complete. Just bringing up the topic so that we communicate on this matter.
Tagging @thober, @rkumar and @lese here.wishlistSebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/144consistent handling of units in mHM2022-04-28T16:07:04+02:00Robert Schweppeconsistent handling of units in mHMWe should have a clear documentation of which physical units are used internally. For example in the current develop in
`mo_snow_accum_melt.f90` in lines 96 there is
```
! Snow pack [m]
REAL(dp), INTENT(INOUT) :: snow_pack
```
a...We should have a clear documentation of which physical units are used internally. For example in the current develop in
`mo_snow_accum_melt.f90` in lines 96 there is
```
! Snow pack [m]
REAL(dp), INTENT(INOUT) :: snow_pack
```
and this variable is passed onto the writing in the netcdf files where in `mo_write_fluxes_states.f90` it says in lines 287
```
tmpvars(ii) = OutputVariable(&
nc, "snowpack", dtype, dims1, nCells, mask1, .true.)
call writeVariableAttributes(tmpvars(ii), "depth of snowpack", "mm")
```
So what is it then - `m` or `mm`?
It should be a starting point for implementing [CF Conventions](https://cfconventions.org/Data/cf-conventions/cf-conventions-1.8/cf-conventions.html) and [Udunits](https://www.unidata.ucar.edu/software/udunits/). Maybe it is also worth checking out an analysis tool that checks for errors in scientific Fortran Code [CamFort](https://github.com/camfort/camfort).wishlist future