mHM issueshttps://git.ufz.de/mhm/mhm/-/issues2019-12-03T22:07:25+01:00https://git.ufz.de/mhm/mhm/-/issues/52Remove branch: mLMv2.02019-12-03T22:07:25+01:00Sebastian MüllerRemove branch: mLMv2.0Please remove the branch ``mLMv2.0``.
If there is still development going on, please fork the mHM repository and continue your work there.
Make a merge request, when your feature is ready.
Thanks a lot!Please remove the branch ``mLMv2.0``.
If there is still development going on, please fork the mHM repository and continue your work there.
Make a merge request, when your feature is ready.
Thanks a lot!slimming down repositoryPallav Kumar Shresthapallav-kumar.shrestha@ufz.dePallav Kumar Shresthapallav-kumar.shrestha@ufz.de2019-12-31https://git.ufz.de/mhm/mhm/-/issues/160cmake error in compiling mhm-develop2020-11-30T14:16:48+01:00Mehmet Cüneyd Demirelcmake error in compiling mhm-developDear @muellese and @thober
I get the following cmake errors. I tried bringing cmake related files from v5.10_fixed but didnt help.
![image](/uploads/4154d36f744e1631ad510adf8080d7b2/image.png)
Also I don't see MakeFile in https://g...Dear @muellese and @thober
I get the following cmake errors. I tried bringing cmake related files from v5.10_fixed but didnt help.
![image](/uploads/4154d36f744e1631ad510adf8080d7b2/image.png)
Also I don't see MakeFile in https://git.ufz.de/mhm/mhm.5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/147fate of MHM2MRM definition2020-10-08T12:03:47+02:00Robert Schweppefate of MHM2MRM definitionCurrently, there is this line in the top-level `CMakeLists.txt`:
```
cpp_definitions("-DMRM2MHM" "CMAKE_MRM2MHM" "ON" "If set to ON the model runs with mRM")
```
so that we be default compile mHM with mRM. If one would turn it off, ther...Currently, there is this line in the top-level `CMakeLists.txt`:
```
cpp_definitions("-DMRM2MHM" "CMAKE_MRM2MHM" "ON" "If set to ON the model runs with mRM")
```
so that we be default compile mHM with mRM. If one would turn it off, there will be errors, e.g:
```
Error: Symbol ‘kge_q’ at (1) has no IMPLICIT type; did you mean ‘kge_et’?
/Users/ottor/nc/Home/local_libs/fortran/mhm_mpr/src/mHM/mo_objective_function.f90:854:63:
854 | call init_indexarray_for_opti_data(domainMeta, 1, nQDomains, opti_domain_indices_Q)
| 1
Error: Symbol ‘nqdomains’ at (1) has no IMPLICIT type; did you mean ‘netdomains’?
```
because `nQDomains` is defined within the `#def MHM2MRM` block but also called outside it.
What is the policy on the MHM2MRM definition (@muellese, @thober)?
- keep it, then we should also test it and fix it (maybe @kaluza?)!
- drop it, then we can get rid of it altogether!5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/142[EVE] NAG loadscript loads wrong netcdf version2020-08-31T16:23:44+02:00Sebastian Müller[EVE] NAG loadscript loads wrong netcdf versionThe module versions in the NAG load scripts are not fixed so they are loading wrong modules now.The module versions in the NAG load scripts are not fixed so they are loading wrong modules now.5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/140Hacky output dirs in test cases2020-11-30T08:58:34+01:00Sebastian MüllerHacky output dirs in test casesMost output directories for the test-cases are given with sth like `output_b1/b1_`.
But this is just a hack to prepend a prefix `b1_` to the output files.
When there will be checks for folders with automatically creation in the future, t...Most output directories for the test-cases are given with sth like `output_b1/b1_`.
But this is just a hack to prepend a prefix `b1_` to the output files.
When there will be checks for folders with automatically creation in the future, this would create two folders `output_b1/b1_/` with the output files in `b1_/`.
This is related to !415.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/128mHM initialization fails for small basins: percentile_0d_dp: n < 22020-09-15T17:19:28+02:00Oldrich RakovecmHM initialization fails for small basins: percentile_0d_dp: n < 2Hi @thober @shresthp (cc @kaluza)
[update 6.7.2020]
After re-running all the 5000+ global basins with the latest mHM develop setup, routing process = 3;
20% of the basin runs are broken during the mRM initialization due to `percentile_0...Hi @thober @shresthp (cc @kaluza)
[update 6.7.2020]
After re-running all the 5000+ global basins with the latest mHM develop setup, routing process = 3;
20% of the basin runs are broken during the mRM initialization due to `percentile_0d_dp: n < 2`
That was not the case earlier (with revision 8271b54 and routing process = 2).
Initially I thought it came with with the bugfix in `./src/mRM/mo_mrm_net_startup.f90` saying:
```fortran
! Stephan Thober, Pallav Kumar Shrestha, Sep 2020 - bug fix in cut off Length at 40 percentile, neglecting links with -9999. that occur if multiple outlets are present
```
lines 1434-1438:
```fortran
! cut off Length at 40 percentile to neglect short paths in headwaters
if ((processMatrix(8, 1) .eq. 2) .or. (processMatrix(8, 1) .eq. 3)) then
length = percentile(pack(nLinkLength(:), nLinkLength(:) .ge. 0._dp), 40._dp)
nLinkLength(:) = merge(nLinkLength(:), length, (nLinkLength(:) .gt. length))
end if
```
But it looks the reason is elsewhere, after rolling it back prior the aforementioned bugfix.
Any hints appreciated (? @kaluza )
Thanks,
Olda5.11Maren KaluzaMaren Kaluzahttps://git.ufz.de/mhm/mhm/-/issues/100Bsymbolic flag in makefile (cmake error)2020-12-01T09:30:59+01:00Mehmet Cüneyd DemirelBsymbolic flag in makefile (cmake error)In Ubuntu TLS (win10), the -Bsymbolic is causing compilation error at the latest stage (100%). After removing it, compilation is successful. May be this is not a bug but a suggestion. @kaluza @thober @ottor
![B3122BDE-52BC-4104-A0F6-A9...In Ubuntu TLS (win10), the -Bsymbolic is causing compilation error at the latest stage (100%). After removing it, compilation is successful. May be this is not a bug but a suggestion. @kaluza @thober @ottor
![B3122BDE-52BC-4104-A0F6-A9563A5B68EB](/uploads/75ff0cccd63a7f7ea46c16ebd3e03782/B3122BDE-52BC-4104-A0F6-A9563A5B68EB.jpeg)
https://stackoverflow.com/questions/15090198/ld-unknown-option-bsymbolic-when-trying-to-build-iniparser-on-osx5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/14NAG compiler, version 6.2, build 6214 does not work on EVE2020-12-01T09:13:32+01:00Robert SchweppeNAG compiler, version 6.2, build 6214 does not work on EVEWith the current develop branch, we get a Segmentation Fault when running on Eve (frontend1):
`make compiler=nag system=eve release=debug && ./mhm`
The code occurs at each time a call to write is encountered, namely in `src/mo_nml.f90`...With the current develop branch, we get a Segmentation Fault when running on Eve (frontend1):
`make compiler=nag system=eve release=debug && ./mhm`
The code occurs at each time a call to write is encountered, namely in `src/mo_nml.f90`, line 308 (this is where the error is thrown):
` write(test, '(A,A)') '&', tolower(name)`
but if we make a workaround to that call, the program raises another SegmentationFault at `src/mo_netcdf.f90`, line 1613:
` write(msg, *) id`
I successfully run and compile the code at my local system with NAG 6.2 (6214). It also applies to other Fortran projects, e.g. MPR. Locally I have gcc version 8.1, netcdf-fortran 4.4.4 compiled with NAG 6.2.
I think it has, something to do with the way the compiler is set up on Eve. Any ideas @rakovec, @krausec, @lberg?5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/156cmake build fails under ubuntu 20.04 with tag 5.10_fixed and tag 5.102020-10-06T15:02:00+02:00sluedtkecmake build fails under ubuntu 20.04 with tag 5.10_fixed and tag 5.10Trying to build mHM fails with the listed setting above.
For tag 5.10_fixed
```
git checkout 5.10_fixed
HEAD is now at b7181fe Update README.md
root@09a3ccc82a3d:/mhm# git status
HEAD detached at 5.10_fixed
nothing to commit, working t...Trying to build mHM fails with the listed setting above.
For tag 5.10_fixed
```
git checkout 5.10_fixed
HEAD is now at b7181fe Update README.md
root@09a3ccc82a3d:/mhm# git status
HEAD detached at 5.10_fixed
nothing to commit, working tree clean
root@09a3ccc82a3d:/mhm# mkdir build && cd build
root@09a3ccc82a3d:/mhm/build# cmake ..
-- The Fortran compiler identification is GNU 9.3.0
-- Check for working Fortran compiler: /usr/bin/f95
-- Check for working Fortran compiler: /usr/bin/f95 -- works
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Checking whether /usr/bin/f95 supports Fortran 90
-- Checking whether /usr/bin/f95 supports Fortran 90 -- yes
-- build INDEPENDENT of module system OFF
-- search in additional directory for netCDF
-- found /usr/bin/nf-config
-- netcdff includes /usr/include
-- netcdff netcdf link flags -I/usr/include
-- netcdff netcdf library link flags -L/usr/lib/x86_64-linux-gnu -lnetcdff -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -lnetcdf -lnetcdf -ldl -lm
-- found /usr/lib/x86_64-linux-gnu/libnetcdff.so
-- found /usr/lib/x86_64-linux-gnu/libnetcdf.so
-- found /usr/lib/x86_64-linux-gnu/libnetcdf.so
-- found /usr/lib/x86_64-linux-gnu/libdl.so
-- found /usr/lib/x86_64-linux-gnu/libm.so
-- found netcdf libraries /usr/lib/x86_64-linux-gnu/libnetcdff.so;/usr/lib/x86_64-linux-gnu/libnetcdf.so;/usr/lib/x86_64-linux-gnu/libnetcdf.so;/usr/lib/x86_64-linux-gnu/libdl.so;/usr/lib/x86_64-linux-gnu/libm.so
-- found netcdf other flags -Wl,-Bsymbolic-functions;-Wl,-z,relro;-Wl,-z,now
-- Performing Test CPP_FLAG
-- Performing Test CPP_FLAG - Success
-- the following debug flags will be used: -g -pedantic-errors -Wall -W -O -g -Wno-maybe-uninitialized
-- Configuring done
-- Generating done
-- Build files have been written to: /mhm/build
root@09a3ccc82a3d:/mhm/build# make
Scanning dependencies of target mhm
[ 1%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_kind.f90.o
[ 1%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_constants.f90.o
[ 2%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_variables.f90.o
[ 3%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_constants.f90.o
[ 4%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_message.f90.o
[ 5%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_global_variables.f90.o
[ 6%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_constants.f90.o
[ 7%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_append.f90.o
[ 8%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_string_utils.f90.o
[ 9%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_utils.f90.o
[ 10%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_upscaling_operators.f90.o
[ 11%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_pet.f90.o
[ 12%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_runoff.f90.o
[ 13%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_smhorizons.f90.o
[ 14%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_soilmoist.f90.o
[ 15%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_multi_param_reg.f90.o
[ 16%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_timer.f90.o
[ 17%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_eval.f90.o
[ 18%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_file.f90.o
[ 19%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_functions.f90.o
[ 20%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_finish.f90.o
[ 21%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_nml.f90.o
[ 22%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_read_config.f90.o
[ 23%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_netcdf.f90.o
[ 24%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_restart.f90.o
[ 25%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_restart.f90.o
[ 26%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_grid.f90.o
[ 27%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_orderpack.f90.o
[ 28%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_read_latlon.f90.o
[ 29%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_soil_database.f90.o
[ 30%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_startup.f90.o
[ 31%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_ncread.f90.o
[ 32%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_julian.f90.o
[ 33%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_read_forcing_nc.f90.o
[ 34%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_prepare_gridded_lai.f90.o
[ 35%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_read_lut.f90.o
[ 36%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_file.f90.o
[ 37%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_read_spatial_data.f90.o
[ 38%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_read_data.f90.o
[ 39%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_read_wrapper.f90.o
[ 39%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mpr_driver.f90.o
[ 40%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_common_read_config.f90.o
[ 41%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_read_timeseries.f90.o
[ 42%] Building Fortran object CMakeFiles/mhm.dir/src/common/mo_template.f90.o
[ 43%] Building Fortran object CMakeFiles/mhm.dir/src/common_mHM_mRM/mo_common_mHM_mRM_file.f90.o
[ 44%] Building Fortran object CMakeFiles/mhm.dir/src/common_mHM_mRM/mo_common_mHM_mRM_variables.f90.o
[ 45%] Building Fortran object CMakeFiles/mhm.dir/src/common_mHM_mRM/mo_common_mHM_mRM_read_config.f90.o
[ 45%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_optimization_utils.f90.o
[ 46%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_xor4096.f90.o
[ 46%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_anneal.f90.o
[ 47%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_dds.f90.o
[ 48%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_moment.f90.o
[ 49%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_ncwrite.f90.o
[ 50%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_mcmc.f90.o
[ 51%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_sce.f90.o
[ 52%] Building Fortran object CMakeFiles/mhm.dir/src/common_mHM_mRM/mo_optimization.f90.o
[ 53%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_corr.f90.o
[ 54%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_errormeasures.f90.o
[ 55%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_linfit.f90.o
[ 56%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_percentile.f90.o
[ 57%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_mad.f90.o
[ 58%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_spatialsimilarity.f90.o
[ 59%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_standard_score.f90.o
[ 60%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_temporal_aggregation.f90.o
[ 61%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_canopy_interc.f90.o
[ 62%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_file.f90.o
[ 63%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_mhm_constants.f90.o
[ 64%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_global_variables.f90.o
[ 65%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_init_states.f90.o
[ 66%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_spatial_agg_disagg_forcing.f90.o
[ 67%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_meteo_forcings.f90.o
[ 68%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_neutrons.f90.o
c[ 69%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_pet.f90.o
[ 70%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_runoff.f90.o
a[ 71%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_snow_accum_melt.f90.o
[ 72%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_soil_moisture.f90.o
[ 73%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_temporal_disagg_forcing.f90.o
m[ 73%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_mhm.f90.o
[ 73%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_constants.f90.o
[ 74%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_global_variables.f90.o
[ 75%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_file.f90.o
[ 76%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_net_startup.f90.o
[ 77%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_mpr.f90.o
[ 78%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_read_config.f90.o
[ 79%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_read_data.f90.o
[ 80%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_restart.f90.o
[ 81%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_river_head.f90.o
[ 82%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_init.f90.o
[ 83%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_routing.f90.o
[ 84%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_write_fluxes_states.f90.o
[ 85%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_write.f90.o
[ 86%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_restart.f90.o
[ 87%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_write_fluxes_states.f90.o
[ 88%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_mhm_eval.f90.o
[ 89%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_mhm_read_config.f90.o
[ 90%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_signatures.f90.o
[ 91%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_objective_function_runoff.f90.o
[ 92%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_objective_function.f90.o
[ 93%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_read_optional_data.f90.o
[ 94%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_set_netcdf_outputs.f90.o
[ 95%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_startup.f90.o
[ 96%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mo_write_ascii.f90.o
[ 97%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mo_mrm_eval.f90.o
[ 98%] Building Fortran object CMakeFiles/mhm.dir/src/mRM/mrm_driver.f90.o
[ 99%] Building Fortran object CMakeFiles/mhm.dir/src/mHM/mhm_driver.f90.o
[100%] Linking Fortran executable mhm
/usr/bin/ld: unrecognized option '-Bsymbolic-functions;-Wl'
/usr/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/mhm.dir/build.make:1649: mhm] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/mhm.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
```
For tag 5.10
```
root@09a3ccc82a3d:/mhm/build# rm -rf *
root@09a3ccc82a3d:/mhm/build# cd ..
root@09a3ccc82a3d:/mhm# git checkout 5.10
Previous HEAD position was b7181fe Update README.md
HEAD is now at 9ce0ec1 merge release into master
root@09a3ccc82a3d:/mhm# cd build/
root@09a3ccc82a3d:/mhm/build# cmake ..
-- The Fortran compiler identification is GNU 9.3.0
-- Check for working Fortran compiler: /usr/bin/f95
-- Check for working Fortran compiler: /usr/bin/f95 -- works
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Checking whether /usr/bin/f95 supports Fortran 90
-- Checking whether /usr/bin/f95 supports Fortran 90 -- yes
-- build INDEPENDENT of module system OFF
-- search in additional directory for netCDF
-- found /usr/bin/nf-config
-- netcdff includes /usr/include
-- netcdff netcdf link flags -I/usr/include
-- netcdff netcdf library link flags -L/usr/lib/x86_64-linux-gnu -lnetcdff -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -lnetcdf -lnetcdf -ldl -lm
-- found /usr/lib/x86_64-linux-gnu/libnetcdff.so
-- found /usr/lib/x86_64-linux-gnu/libnetcdf.so
-- found /usr/lib/x86_64-linux-gnu/libnetcdf.so
-- found /usr/lib/x86_64-linux-gnu/libdl.so
-- found /usr/lib/x86_64-linux-gnu/libm.so
-- found netcdf libraries /usr/lib/x86_64-linux-gnu/libnetcdff.so;/usr/lib/x86_64-linux-gnu/libnetcdf.so;/usr/lib/x86_64-linux-gnu/libnetcdf.so;/usr/lib/x86_64-linux-gnu/libdl.so;/usr/lib/x86_64-linux-gnu/libm.so
-- found netcdf other flags -Wl,-Bsymbolic-functions;-Wl,-z,relro;-Wl,-z,now
-- Performing Test CPP_FLAG
-- Performing Test CPP_FLAG - Success
-- the following debug flags will be used: -g -pedantic-errors -Wall -W -O -g -Wno-maybe-uninitialized
-- Configuring done
-- Generating done
-- Build files have been written to: /mhm/build
root@09a3ccc82a3d:/mhm/build# make
Scanning dependencies of target mhm
[ 1%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_kind.f90.o
[ 2%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_constants.f90.o
[ 4%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_constants.f90.o
[ 5%] Building Fortran object CMakeFiles/mhm.dir/src/lib/mo_message.f90.o
[ 6%] Building Fortran object CMakeFiles/mhm.dir/src/MPR/mo_mpr_global_variables.f90.o
/mhm/src/MPR/mo_mpr_global_variables.f90:17:6:
17 | use mo_common_variables, only : period
| 1
Fatal Error: Cannot open module file 'mo_common_variables.mod' for reading at (1): No such file or directory
compilation terminated.
make[2]: *** [CMakeFiles/mhm.dir/build.make:102: CMakeFiles/mhm.dir/src/MPR/mo_mpr_global_variables.f90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:76: CMakeFiles/mhm.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
```
The current HEAD of `develop` build successfully.
On my local machine (Manjaro), the tag 5.10_fixed and head of develop build successfully, but not 5.10, that fails with the same error as on Ubuntu.5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/155[RELEASE] 5.11 checklist2021-02-03T11:47:28+01:00Sebastian Müller[RELEASE] 5.11 checklist- **Release notes**
- [x] notes about River temperature module !37
- [x] notes about new SM process !43
- **Clean-ups**
- [x] remove `testingInstructions`
- [x] remove `mRM` standalone specific files (not working as standalone...- **Release notes**
- [x] notes about River temperature module !37
- [x] notes about new SM process !43
- **Clean-ups**
- [x] remove `testingInstructions`
- [x] remove `mRM` standalone specific files (not working as standalone anymore)
- [x] remove Makefile and related folders (new features not implemented there [cpp directives etc.])
- [x] remove `bash` folder
- **Documentation**
- [x] set `tocdepth` to `1` in `header_doxygen.tex`
- [x] proof reading of documentation pages (@thober, @lese)
- [x] cleanup `doc` folder
- [x] move `INSTALL.md` and other additional `*.md` files there
- [x] add intel-2020 workflow to `INSTALL.md`
- **Release Procedure**
- [x] create `release_5.11.0` branch from `develop` at point of feature stop
- [x] provide a `5.11.0-rc1` release candidate from this branch as pre-release to check release process
- [x] when ready update `version.txt` and `version_date.txt`
- [x] merge into `master`
- [x] make release `5.11.0` from `master`
- [x] merge updates made during release back to develop
- [x] set `version.txt` to `5.11.1-dev0`5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/152Add iomkl/2020a workflow to eve load-scripts and CI2020-09-24T15:11:21+02:00Sebastian MüllerAdd iomkl/2020a workflow to eve load-scripts and CIIOMKL 2020a comes with the following settings:
- Intel C Compiler v2020.1
- Intel Fortran Compiler v2020.1
- OpenMPI v4.0.3
- Intel MKL v2020.1IOMKL 2020a comes with the following settings:
- Intel C Compiler v2020.1
- Intel Fortran Compiler v2020.1
- OpenMPI v4.0.3
- Intel MKL v2020.15.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/151module loads under easybuild in INSTALL.md2020-10-05T13:48:25+02:00Friedrich Boeingmodule loads under easybuild in INSTALL.mdHello,
The INSTALL.md could be updated by directing to the moduleloadscripts under the different compilers with easybuild.
The solution for loading intel modules `module purge
ml uge/8.5.5-2 Java/1.8.0_202 grid-engine-tools/0.8.3-3-g93...Hello,
The INSTALL.md could be updated by directing to the moduleloadscripts under the different compilers with easybuild.
The solution for loading intel modules `module purge
ml uge/8.5.5-2 Java/1.8.0_202 grid-engine-tools/0.8.3-3-g93f1efa icc/2018.3.222-GCC-7.3.0-2.30 ifort/2018.3.222-GCC-7.3.0-2.30 iccifort/2018.3.222-GCC-7.3.0-2.30
`
currently proposed in INSTALL.md is not up to date as still old modules are used there, which would crash in Nov 2020 when all old modules are deleted (according to Tom Strempel).
Best regards,
Friedrich5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/143[Version] intrducing bugfix-releases with v5.112020-10-05T13:49:45+02:00Sebastian Müller[Version] intrducing bugfix-releases with v5.11In order to provide bugfixes for minor releases, we should introduce **micro** releases with `v5.11`
We should follow the semantic versioning: https://semver.org/In order to provide bugfixes for minor releases, we should introduce **micro** releases with `v5.11`
We should follow the semantic versioning: https://semver.org/5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/130unit vs units in netCDF output2020-10-08T20:17:36+02:00Pallav Kumar Shresthapallav-kumar.shrestha@ufz.deunit vs units in netCDF output* ncdump -h of mHM's netCDF output shows that the name used for unit/units are not uniform.
* The word **units** is used for the attribute of grid variables. This is usually the case/ found elsewhere.
* The word **unit** is used for...* ncdump -h of mHM's netCDF output shows that the name used for unit/units are not uniform.
* The word **units** is used for the attribute of grid variables. This is usually the case/ found elsewhere.
* The word **unit** is used for the attribute of mHM variables.
This is minor issue. However, ratifying this would reduce some lines of post processing of mHM (e.g. in forecasting chains).5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/103Remap types duplication2020-10-08T12:03:47+02:00Pallav Kumar Shresthapallav-kumar.shrestha@ufz.deRemap types duplicationmo_common_variables and mo_mrm_global_variables both have declarations for l0_l11_remap and l1_l11_remap. @thober
* Is this necessary or duplication?
* If its duplication, where should the declaration be housed?
The ![Screenshot_20...mo_common_variables and mo_mrm_global_variables both have declarations for l0_l11_remap and l1_l11_remap. @thober
* Is this necessary or duplication?
* If its duplication, where should the declaration be housed?
The ![Screenshot_2020-04-27_at_18.53.40](/uploads/1e1e2c8fc179331142e58c0affa916e8/Screenshot_2020-04-27_at_18.53.40.png)5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/102PET unit documentation2020-11-30T12:55:14+01:00Sebastian MüllerPET unit documentationIn [`mo_pet.f90`](https://git.ufz.de/mhm/mhm/blob/develop/src/mHM/mo_pet.f90), `pet_hargreaves` and `pet_penman` are documented to be in `mm/s` but actually all PET routines return `mm/TS`. (TS - timestep)In [`mo_pet.f90`](https://git.ufz.de/mhm/mhm/blob/develop/src/mHM/mo_pet.f90), `pet_hargreaves` and `pet_penman` are documented to be in `mm/s` but actually all PET routines return `mm/TS`. (TS - timestep)5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/101Redundant constants2020-11-30T12:55:15+01:00Sebastian MüllerRedundant constants`Stefan-Boltzmann constant`:
https://git.ufz.de/mhm/mhm/blob/develop/src/mHM/mo_mhm_constants.f90#L37
is already defined here:
https://git.ufz.de/mhm/mhm/blob/develop/src/lib/mo_constants.f90#L106
The first one is not used ATM.`Stefan-Boltzmann constant`:
https://git.ufz.de/mhm/mhm/blob/develop/src/mHM/mo_mhm_constants.f90#L37
is already defined here:
https://git.ufz.de/mhm/mhm/blob/develop/src/lib/mo_constants.f90#L106
The first one is not used ATM.5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/98mHM states_fluxes netCDF output are curvilinear even if coordinate system is ...2020-12-01T09:16:41+01:00Pallav Kumar Shresthapallav-kumar.shrestha@ufz.demHM states_fluxes netCDF output are curvilinear even if coordinate system is set to regular latlon in mhm.nml* It was noted that the output netCDF files of mHM are saved as curvilinear irrespective of the coordinate system set in mhm.nml. I am working in regular latlon system but the mHM output according to CDO and NCO are in curvilinear syste...* It was noted that the output netCDF files of mHM are saved as curvilinear irrespective of the coordinate system set in mhm.nml. I am working in regular latlon system but the mHM output according to CDO and NCO are in curvilinear system as shown in screenshots below.
* The issue "seems" to be that the lat and lon are stored as 2D variable even for regular latlon system. This makes cdo and nco to assume its a curvilinear system. Storing the lat and lon as a vector instead should solve the problem @thober @schaefed @muellese (???)
cdo sinfo on the output file:
![Screenshot_2020-03-09_at_11.59.46](/uploads/520c7779a3e1bfe8bb9abf6572f67411/Screenshot_2020-03-09_at_11.59.46.png)
ncdump -h on the output file:
![Screenshot_2020-03-09_at_12.00.14](/uploads/d71e769affaec7f9380dfa508fb5f895/Screenshot_2020-03-09_at_12.00.14.png)
cdo griddes on the output file:
![Screenshot_2020-03-09_at_12.01.22](/uploads/e93d2881842dc5d0af0593073d7a2cce/Screenshot_2020-03-09_at_12.01.22.png)
cdo griddes on the input regular latlon pre.nc file for comparison:
![Screenshot_2020-03-09_at_12.02.37](/uploads/9a246d6649ae186bec744806ccea1d4c/Screenshot_2020-03-09_at_12.02.37.png)5.11Stephan ThoberStephan Thoberhttps://git.ufz.de/mhm/mhm/-/issues/97File: mo_restart.f90 Line 6452020-09-10T12:12:26+02:00Mehmet Cüneyd DemirelFile: mo_restart.f90 Line 645Hello @thober and @ottor,
I think, in line 645 in mo_restart.f90 we are mission option 3 in SM.
So this line
if (processMatrix(3, 1) == 2) then
should be
if (processMatrix(3, 1) == 2 .OR. processMatrix(3, 1) == 3) then
or w...Hello @thober and @ottor,
I think, in line 645 in mo_restart.f90 we are mission option 3 in SM.
So this line
if (processMatrix(3, 1) == 2) then
should be
if (processMatrix(3, 1) == 2 .OR. processMatrix(3, 1) == 3) then
or we add a new paragraph like below as in processMatrix(3, 1) both options 2 and 3 have Jarvis in soil moisture calculations.
if (processMatrix(3, 1) == 3) then
! jarvis critical value for normalized soil water content
var = nc%getVariable("L1_jarvis_thresh_c1")
call var%getData(dummyD2)
L1_jarvis_thresh_c1(s1 : e1, 1, 1) = pack(dummyD2, mask1)
end if5.11Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/issues/95check first if output folders are present2020-11-30T08:58:33+01:00Stephan Thobercheck first if output folders are presentmHM does not check whether output files and folders exist at the beginning. This leads to annoying model behaviour.
@ottor : please provide assert functionmHM does not check whether output files and folders exist at the beginning. This leads to annoying model behaviour.
@ottor : please provide assert function5.11Sebastian MüllerSebastian Müller