consistent handling of units in mHM
We should have a clear documentation of which physical units are used internally. For example in the current develop in
mo_snow_accum_melt.f90
in lines 96 there is
! Snow pack [m]
REAL(dp), INTENT(INOUT) :: snow_pack
and this variable is passed onto the writing in the netcdf files where in mo_write_fluxes_states.f90
it says in lines 287
tmpvars(ii) = OutputVariable(&
nc, "snowpack", dtype, dims1, nCells, mask1, .true.)
call writeVariableAttributes(tmpvars(ii), "depth of snowpack", "mm")
So what is it then - m
or mm
?
It should be a starting point for implementing CF Conventions and Udunits. Maybe it is also worth checking out an analysis tool that checks for errors in scientific Fortran Code CamFort.