Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • mHM mHM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mhmmhm
  • mHMmHM
  • Issues
  • #147
Closed
Open
Issue created Sep 08, 2020 by Robert Schweppe@ottorMaintainer

fate of MHM2MRM definition

Currently, there is this line in the top-level CMakeLists.txt:

cpp_definitions("-DMRM2MHM" "CMAKE_MRM2MHM" "ON" "If set to ON the model runs with mRM")

so that we be default compile mHM with mRM. If one would turn it off, there will be errors, e.g:

Error: Symbol ‘kge_q’ at (1) has no IMPLICIT type; did you mean ‘kge_et’?
/Users/ottor/nc/Home/local_libs/fortran/mhm_mpr/src/mHM/mo_objective_function.f90:854:63:

  854 |     call init_indexarray_for_opti_data(domainMeta, 1, nQDomains, opti_domain_indices_Q)
      |                                                               1
Error: Symbol ‘nqdomains’ at (1) has no IMPLICIT type; did you mean ‘netdomains’?

because nQDomains is defined within the #def MHM2MRM block but also called outside it.

What is the policy on the MHM2MRM definition (@muellese, @thober)?

  • keep it, then we should also test it and fix it (maybe @kaluza?)!
  • drop it, then we can get rid of it altogether!
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking