Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • mHM mHM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 50
    • Issues 50
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mhmmhm
  • mHMmHM
  • Issues
  • #187
Closed
Open
Issue created Apr 22, 2021 by Nicola Nadine Döring@doeringnContributor

unreachable else branch in feddes_et_reduction

https://git.ufz.de/mhm/mhm/-/blob/175eff0ba82690418410d8c0703694a64b7e8c8c/src/mHM/mo_soil_moisture.f90#L353 should be:

      !    SM >= FC
    if (soil_moist >= soil_moist_FC) then
      feddes_et_reduction = frac_roots
      ! PW < SM < FC
    else if (soil_moist > wilting_point) then
      feddes_et_reduction = frac_roots * (soil_moist - wilting_point) / (soil_moist_FC - wilting_point)
      ! SM <= PW
    else
      feddes_et_reduction = 0.0_dp
    end if
Edited Apr 22, 2021 by Nicola Nadine Döring
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking