mHM merge requestshttps://git.ufz.de/mhm/mhm/-/merge_requests2024-03-13T09:39:38+01:00https://git.ufz.de/mhm/mhm/-/merge_requests/103v5: add FORCES as dependency2024-03-13T09:39:38+01:00Sebastian Müllerv5: add FORCES as dependencyThis MR adds FORCES v0.2 as dependency.
- rename f90 files with preproc directives to F90
- update CMake
- minor fixes to be compatible with new lib version
- added cmake and hpc-module-loads subrepos
- "L1_LAITimesteps_bnds" ignored in ...This MR adds FORCES v0.2 as dependency.
- rename f90 files with preproc directives to F90
- update CMake
- minor fixes to be compatible with new lib version
- added cmake and hpc-module-loads subrepos
- "L1_LAITimesteps_bnds" ignored in checks, since changed bounds shape (2,12) -> (12,2)v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/39Hourly forcings2024-03-07T10:42:27+01:00Stephan ThoberHourly forcingsI fixed the reading of hourly input. I did not include a check case for this.
@muellese: What do you think? Should we create a check case. If so, it would be good to know whether we can use the data that Olda provided in issue #107.I fixed the reading of hourly input. I did not include a check case for this.
@muellese: What do you think? Should we create a check case. If so, it would be good to know whether we can use the data that Olda provided in issue #107.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/136Release 5.122022-10-04T16:38:52+02:00Sebastian MüllerRelease 5.12Closes #231 #227
Finalize the 5.12 release.Closes #231 #227
Finalize the 5.12 release.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/135Discharge NetCDF output fix2022-08-30T14:42:42+02:00Sebastian MüllerDischarge NetCDF output fixCloses #220Closes #220v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/133doc: set table widths to 100%2022-08-30T14:22:16+02:00Sebastian Müllerdoc: set table widths to 100%closes #232closes #232v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/134CI: Fix fetch tags for newer gitlab-runner versions2022-07-13T17:36:07+02:00Sebastian MüllerCI: Fix fetch tags for newer gitlab-runner versionsUpdating the gitlab runner to v15 introduced an error while fetching tags for the stable documentation.Updating the gitlab runner to v15 introduced an error while fetching tags for the stable documentation.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/127Output: add '_FillValue' alongside 'missing_value' in nc output2022-07-07T10:38:57+02:00Sebastian MüllerOutput: add '_FillValue' alongside 'missing_value' in nc outputCloses #159
We never added the attribute `_FillValue` to the netcdf output files.
`_FillValue` is used to fill data arrays that were not yet written and is used to indicate missing data (`"missing_value"` is more meant for documentati...Closes #159
We never added the attribute `_FillValue` to the netcdf output files.
`_FillValue` is used to fill data arrays that were not yet written and is used to indicate missing data (`"missing_value"` is more meant for documentation):
- https://docs.unidata.ucar.edu/netcdf-c/current/attribute_conventions.html
- https://github.com/Unidata/netcdf4-python/issues/632v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/56mo_grid: replace ceiling with nint2022-07-07T10:38:32+02:00Sebastian Müllermo_grid: replace ceiling with nintFixes #126 #131
Fortran intrinsic ceiling was used to calculate Ncols, Nrows which is now done by `nint` in order to be stable when cell factor is close to 1.Fixes #126 #131
Fortran intrinsic ceiling was used to calculate Ncols, Nrows which is now done by `nint` in order to be stable when cell factor is close to 1.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/132Master: include tags in develop history2022-07-07T10:35:00+02:00Sebastian MüllerMaster: include tags in develop history`git describe --tags` was not able to find latest tags on develop, since tags were created from master.
Another reason to remove the `master` branch and keep simply the develop branch.`git describe --tags` was not able to find latest tags on develop, since tags were created from master.
Another reason to remove the `master` branch and keep simply the develop branch.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/130Update cmake scripts to v1.72022-06-22T14:35:05+02:00Sebastian MüllerUpdate cmake scripts to v1.7https://git.ufz.de/chs/cmake-fortran-scripts/-/releases/v1.7https://git.ufz.de/chs/cmake-fortran-scripts/-/releases/v1.7v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/124update Install instructions with special treatment of the forces dependency2022-06-17T21:00:14+02:00Sebastian Müllerupdate Install instructions with special treatment of the forces dependencyCloses #222 #214
- update doc
- update install instructions for all systems
- separate cygwin details
- addition infos on forces and cmake
- add option to place a copy of forces in the root directory to prevent downloadingCloses #222 #214
- update doc
- update install instructions for all systems
- separate cygwin details
- addition infos on forces and cmake
- add option to place a copy of forces in the root directory to prevent downloadingv5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/125Writeout fixes2022-06-17T20:59:44+02:00Sebastian MüllerWriteout fixesCloses #229 #228
- change units of easting/northing to `"m"`
- add line breaks in `ConfigFile.log` for simulation periodsCloses #229 #228
- change units of easting/northing to `"m"`
- add line breaks in `ConfigFile.log` for simulation periodsv5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/128Input files: better warnings for reading errors2022-06-17T20:59:14+02:00Sebastian MüllerInput files: better warnings for reading errorsCloses #132 #133 #77Closes #132 #133 #77v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/126output: add snow melt flux output2022-06-17T20:58:53+02:00Sebastian Mülleroutput: add snow melt flux outputcloses #173 #149
added output option for snow melt fluxcloses #173 #149
added output option for snow melt fluxv5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/98Bring neutron module to develop2022-06-17T20:58:01+02:00Stephan ThoberBring neutron module to developThis brings the neutron module to the current development branch.This brings the neutron module to the current development branch.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/129Checks: deactivate case_11 for MPI (strange behavior)2022-06-17T19:37:02+02:00Sebastian MüllerChecks: deactivate case_11 for MPI (strange behavior)CI is failing occasionally because of Check case 11 running with MPI.
Deactivating for now.CI is failing occasionally because of Check case 11 running with MPI.
Deactivating for now.v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/108V5 add run interfaces2022-06-17T16:13:44+02:00Sebastian MüllerV5 add run interfacesBackport of the run interfaces from !94
Refactor mhm_eval: copy everything into subroutines
- remove PGI pre-processor directives
- new module: `mo_mhm_interface_run.f90`
```fortran
use mo_mhm_interface_run, only : &
mhm_interfa...Backport of the run interfaces from !94
Refactor mhm_eval: copy everything into subroutines
- remove PGI pre-processor directives
- new module: `mo_mhm_interface_run.f90`
```fortran
use mo_mhm_interface_run, only : &
mhm_interface_run_prepare, &
mhm_interface_run_get_ndomains, &
mhm_interface_run_prepare_domain, &
mhm_interface_run_finished, &
mhm_interface_run_do_time_step, &
mhm_interface_run_write_output, &
mhm_interface_run_update_optisim, &
mhm_interface_run_finalize_domain, &
mhm_interface_run_finalize
```
- use subroutines for every step in the eval routine:
```fortran
! prepare the mhm run
call mhm_interface_run_prepare(parameterset, opti_domain_indices, present(runoff))
! get number of domains to loop over
call mhm_interface_run_get_ndomains(nDomains)
! loop over Domains
DomainLoop: do ii = 1, nDomains
! prepare current domain
call mhm_interface_run_prepare_domain(ii, etOptiSim, twsOptiSim, neutronsOptiSim, smOptiSim)
! run time-loop at least once
time_loop_finished = .false.
! Loop over time
TimeLoop: do while(.not. time_loop_finished)
! do one time-step on current domain
call mhm_interface_run_do_time_step()
! write output
call mhm_interface_run_write_output()
! update optisim data
call mhm_interface_run_update_optisim(etOptiSim, twsOptiSim, neutronsOptiSim, smOptiSim)
! check whether to run the time-loop further
call mhm_interface_run_finished(time_loop_finished)
end do TimeLoop !<< TIME STEPS LOOP
! finalize domain
call mhm_interface_run_finalize_domain()
end do DomainLoop !<< Domain LOOP
! SET RUNOFF OUTPUT VARIABLE; reset init-flag for MPR
call mhm_interface_run_finalize(runoff)
```v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/70Back to work 5.11.2-dev02022-06-17T13:56:44+02:00Sebastian MüllerBack to work 5.11.2-dev0Back to work after release of 5.11.1Back to work after release of 5.11.1v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/885.11.3-dev0: back to work2022-06-17T13:56:30+02:00Sebastian Müller5.11.3-dev0: back to workback to work after 5.11.2back to work after 5.11.2v5.12Sebastian MüllerSebastian Müllerhttps://git.ufz.de/mhm/mhm/-/merge_requests/110slope_tmp allocated2022-06-17T13:56:00+02:00Pallav Kumar Shresthapallav-kumar.shrestha@ufz.deslope_tmp allocatedThe `L11_calc_celerity` subroutine in `mo_mrm_net_startup` uses a variable `slope_tmp` which has been declared but not allocated. This is not an issue normally as `slope_tmp` is given values and deallocated at the end. However, when numb...The `L11_calc_celerity` subroutine in `mo_mrm_net_startup` uses a variable `slope_tmp` which has been declared but not allocated. This is not an issue normally as `slope_tmp` is given values and deallocated at the end. However, when number of nodes is 1, `slope_tmp` is not given any values and mhm throws error at deallocation.
Thanks to **Prabhat Banjara** (Institute of Engineering, Nepal) for finding out the bug where one of his domain was small enough to be included in a single mhm pixel, leading to this error.v5.12Sebastian MüllerSebastian Müller