Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • mHM mHM
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • mhmmhm
  • mHMmHM
  • Merge requests
  • !139

Output: unification, selectable time reference point and bounds for all coordinates

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastian Müller requested to merge muellese/mhm:datetime_increment_fix into develop Nov 22, 2022
  • Overview 32
  • Commits 18
  • Pipelines 7
  • Changes 17

Solves #83

There was a discontinuity in the internal time each day at 23h for hourly time stepping. Here is an example (printout for the test-domain):

y    m d h
1990 1 1 22
1990 1 2 23
1990 1 2 00

The day was already incremented at 23h since time-step is added twice as @thober correctly indicated. This also meant, that newTime doesn't hold the next but the second next time.

Changes

  • added option output_time_reference[_mrm] to m[h|r]m_outputs.nml where users can now select the reference time stamp for the current time interval:
    location of reference time point in outputs:
     0: start of the time interval (i.e. 1990-01-01 00:00 for daily output on 1990-01-01)
     1: center of the time interval (i.e. 1990-01-01 12:00 for daily output on 1990-01-01)
     2: end of the time interval (i.e. 1990-01-02 00:00 for daily output on 1990-01-01)
    • This will be 0 by default. Before it was always the end of the time interval -1h (that is why we always had 23h as timestamp)
    • When using the start of the time interval we actually match the time-stamps of the gauge time-series (that was shifted in discharge.nc)
    • When using center of time interval output unit may change to minutes (to get center of an hour)
  • added time_bnds to all netcdf outputs to explicitly describe the time-span for the given time-stamp (following cf-conventions)
  • addad axis attribute to all coordinates in all netcdf outputs (following cf-conventions)
  • added bounds for all spatial coordinate axes (either easting/northing or lon/lat)
  • unified output handling in mo_nc_output
  • use new output handler for groundwater coupling
  • fixed indexing in groundwater coupling calculations
Edited Dec 02, 2022 by Sebastian Müller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: datetime_increment_fix