From 1853e3a7dc1938046bffccfa1f5dc6555df789cb Mon Sep 17 00:00:00 2001
From: Bert Palm <bert.palm@ufz.de>
Date: Mon, 30 May 2022 23:04:23 +0200
Subject: [PATCH] FIX: bug in raising informative in __main__
---
saqc/__main__.py | 4 ++--
tests/test__main__.py | 14 ++++++++++++++
2 files changed, 16 insertions(+), 2 deletions(-)
create mode 100644 tests/test__main__.py
diff --git a/saqc/__main__.py b/saqc/__main__.py
index 0b1a5c84b..34cfb73ce 100644
--- a/saqc/__main__.py
+++ b/saqc/__main__.py
@@ -51,7 +51,7 @@ def readData(reader_dict, fname):
reader = reader_dict.get(extension)
if not reader:
raise ValueError(
- f"Unsupported file format '{extension}', use one of {tuple(reader.keys())}"
+ f"Unsupported file format '{extension}', use one of {tuple(reader_dict.keys())}"
)
return reader(fname)
@@ -61,7 +61,7 @@ def writeData(writer_dict, df, fname):
writer = writer_dict.get(extension)
if not writer:
raise ValueError(
- f"Unsupported file format '{extension}', use one of {tuple(writer.keys())}"
+ f"Unsupported file format '{extension}', use one of {tuple(writer_dict.keys())}"
)
writer(df, fname)
diff --git a/tests/test__main__.py b/tests/test__main__.py
new file mode 100644
index 000000000..a1fce8f1b
--- /dev/null
+++ b/tests/test__main__.py
@@ -0,0 +1,14 @@
+#!/usr/bin/env python
+import pytest
+import numpy as np
+import pandas as pd
+
+
+def test_unknownFileExtention():
+ from saqc.__main__ import readData, writeData, setupIO
+
+ reader, writer = setupIO(np.nan)
+ with pytest.raises(ValueError):
+ readData(reader, "foo.unknown")
+ with pytest.raises(ValueError):
+ writeData(reader, pd.DataFrame(), "foo.unknown")
--
GitLab