From 93e3ca67a647f40d1e389ea8497c2a5061095847 Mon Sep 17 00:00:00 2001
From: Peter Luenenschloss <peter.luenenschloss@ufz.de>
Date: Tue, 4 Aug 2020 06:48:53 +0200
Subject: [PATCH] minor nicer

---
 saqc/funcs/data_modelling.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/saqc/funcs/data_modelling.py b/saqc/funcs/data_modelling.py
index c0c9344b9..5d9b5104f 100644
--- a/saqc/funcs/data_modelling.py
+++ b/saqc/funcs/data_modelling.py
@@ -273,13 +273,15 @@ def modelling_mask(data, field, flagger, mode, loc_var=None, season_start=None,
         else:
             overlap = True
 
-        def _selector(x, overlap=overlap, start=season_start, end=season_end):
-            if not overlap:
+        if not overlap:
+            def _selector(x, start=season_start, end=season_end):
                 x[_composeStamp(x.index, start):_composeStamp(x.index, end)] = True
-            else:
+                return x
+        else:
+            def _selector(x, start=season_start, end=season_end):
                 x[:_composeStamp(x.index, start)] = True
                 x[_composeStamp(x.index, end):] = True
-            return x
+                return x
         freq = '1' + 'mmmhhhdddMMMYYY'[len(season_start)]
         seasonal_mask = mask.groupby(pd.Grouper(freq=freq)).transform(_selector)
 
-- 
GitLab