translate 'dfilter'

We currently don't translate the dfilter value, which is inconsistent and inconvenient.

changed milestone to %2.0

added question label

What to you mean by translate? Do you ask, if we call self._translator(to_mask)? If so, then the answer is no, we don't translate it. This is a BUG, I guess. However, this could be easily fixed here.

There is just one related issue, I currently don't get my head around. We allow every translator to have it's on to_mask default, defined here. I just don't quite remember, why we went for the type Union[float, bool]. I do remember, that we discussed the usefulness of something like to_mask=False, but what should to_mask=True do? If that is not a case, maybe we could solve the to_mask=False case, with an actual float value (maybe using -np.inf).

Do you ask, if we call self._translator(to_mask)?

yes

added BUG label

assigned to @schaefed

Conclusion:

• translate to_mask
• change Translator.TO_MASK: bool | float to Translator.TO_MASK: float

removed question label

mentioned in merge request !350 (merged)

mentioned in commit e675930c

closed with merge request !350 (merged)

reopened

changed milestone to %2.3.0

closed

reopened

changed title from translate 'to_mask' to translate 'dfilter'

changed the description

added accepted label

added internal architecture label

added category: register/core usability labels

added category: public API label

mentioned in merge request !429 (merged)

changed milestone to %2.2.0

mentioned in merge request !522 (merged)

closed with merge request !522 (merged)

mentioned in commit 008ecb4f

mentioned in commit 63b55c6d

mentioned in commit 684dc8a0

mentioned in commit 8f7a90e4