Skip to content
Snippets Groups Projects
Commit c5e056e2 authored by Martin Lange's avatar Martin Lange
Browse files

store logger only if base logger name is available

parent e5d6da9d
No related branches found
No related tags found
1 merge request!224Cache loggers
Pipeline #133467 passed with stages
in 5 minutes and 39 seconds
...@@ -57,6 +57,12 @@ class Loggable(ABC): ...@@ -57,6 +57,12 @@ class Loggable(ABC):
def logger(self): def logger(self):
"""Logger for this component.""" """Logger for this component."""
if self._logger is None: if self._logger is None:
if (
self.uses_base_logger_name
and hasattr(self, "base_logger_name")
and getattr(self, "base_logger_name") is None
):
return logging.getLogger(self.logger_name)
self._logger = logging.getLogger(self.logger_name) self._logger = logging.getLogger(self.logger_name)
return self._logger return self._logger
......
...@@ -6,7 +6,6 @@ from ..data import tools ...@@ -6,7 +6,6 @@ from ..data import tools
from ..interfaces import ComponentStatus, IInput from ..interfaces import ComponentStatus, IInput
from ..sdk import CallbackInput, Component, TimeComponent from ..sdk import CallbackInput, Component, TimeComponent
from ..tools.date_helper import is_timedelta from ..tools.date_helper import is_timedelta
from ..tools.log_helper import ErrorLogger
class DebugConsumer(TimeComponent): class DebugConsumer(TimeComponent):
...@@ -73,11 +72,10 @@ class DebugConsumer(TimeComponent): ...@@ -73,11 +72,10 @@ class DebugConsumer(TimeComponent):
): ):
super().__init__() super().__init__()
with ErrorLogger(self.logger): if not isinstance(start, datetime):
if not isinstance(start, datetime): raise ValueError("Start must be of type datetime")
raise ValueError("Start must be of type datetime") if not is_timedelta(step):
if not is_timedelta(step): raise ValueError("Step must be of type timedelta or relativedelta")
raise ValueError("Step must be of type timedelta or relativedelta")
self._strip_data = strip_data self._strip_data = strip_data
self._log_data = None self._log_data = None
...@@ -212,7 +210,6 @@ class DebugPushConsumer(Component): ...@@ -212,7 +210,6 @@ class DebugPushConsumer(Component):
def __init__(self, inputs, callbacks=None, log_data=False, strip_data=True): def __init__(self, inputs, callbacks=None, log_data=False, strip_data=True):
super().__init__() super().__init__()
self._strip_data = strip_data self._strip_data = strip_data
self._log_data = None self._log_data = None
if isinstance(log_data, bool): if isinstance(log_data, bool):
......
...@@ -6,7 +6,6 @@ from finam.interfaces import ComponentStatus ...@@ -6,7 +6,6 @@ from finam.interfaces import ComponentStatus
from ..sdk import Component, TimeComponent from ..sdk import Component, TimeComponent
from ..tools.date_helper import is_timedelta from ..tools.date_helper import is_timedelta
from ..tools.log_helper import ErrorLogger
class CallbackGenerator(TimeComponent): class CallbackGenerator(TimeComponent):
...@@ -54,11 +53,11 @@ class CallbackGenerator(TimeComponent): ...@@ -54,11 +53,11 @@ class CallbackGenerator(TimeComponent):
def __init__(self, callbacks, start, step): def __init__(self, callbacks, start, step):
super().__init__() super().__init__()
with ErrorLogger(self.logger):
if not isinstance(start, datetime): if not isinstance(start, datetime):
raise ValueError("Start must be of type datetime") raise ValueError("Start must be of type datetime")
if not is_timedelta(step): if not is_timedelta(step):
raise ValueError("Step must be of type timedelta or relativedelta") raise ValueError("Step must be of type timedelta or relativedelta")
self._callbacks = callbacks self._callbacks = callbacks
self._step = step self._step = step
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment