Skip to content
Snippets Groups Projects

Improve predict_mixture

Merged Sebastian Henz requested to merge develop into master

description

Multiple changes to predict_mixture.

  • The concentration vectors are checked for NAs, which raise an error when found.
  • The use of drc::ED() was replaced with a custom inverse weibull function, which does the same but better.
  • predict_mixture() accepts multiple values for the concentration of the second toxicant. Both concentration vectors must be the same length.
  • predict_mixture() returns a data frame with the concentrations and effects. Previously it was only a vector of effects.
  • predict_mixture() received a new argument "effect_max" which scales the returned effect values.
  • Renamed the arguments of predict_mixture() to use underscore letters a and b instad of 1 and 2. For example model_1 is now model_a.

system details

  • RStudio Version: Version 1.2.5033
  • R Version: 3.6.3
  • OS Version: Windows 10 x64 (build 18363)

checklist

  • This merge introduces new features.
    • new features are documented
    • new features have tests
  • update documentation including examples (if necessary)
  • update and polish NEWS.md
  • update version in DESCRIPTION
  • update date in DESCRIPTION
  • no remaining TODO, FIXME, or debug prints anywhere in the source files
  • devtools::document()
  • devtools::check() without errors or warnings
Edited by Sebastian Henz

Merge request reports

Merge request pipeline #3013 passed

Merge request pipeline passed for c1e37a58

Approval is optional

Merged by Sebastian HenzSebastian Henz 5 years ago (Mar 11, 2020 3:56pm UTC)

Pipeline #3014 passed

Pipeline passed for 70d1e20e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading