Merge branch 'concatFlags_default' into 'develop'

changed value of the default parameter overwrite for concatFlags to False

See merge request !604

CHANGELOG.md

@@ -16,7 +16,8 @@ SPDX-License-Identifier: GPL-3.0-or-later
 - Remove all flag value restrictions from the default flagging scheme `FloatTranslator` 
 - Renamed `TranslationScheme.forward` to `TranslationScheme.toInternal` 
 - Renamed `TranslationScheme.backward` to `TranslationScheme.toExternal` 
-- Changed Default value of the parameter `limit` for `SaQC.interpolateIndex` and `SaQC.interpolateInvalid` to ``None`
+- Changed default value of the parameter `limit` for `SaQC.interpolateIndex` and `SaQC.interpolateInvalid` to ``None``
+- Changed default value of the parameter ``overwrite`` for ``concatFlags`` to ``False``
 ### Removed
 - python 3.7 support
 ### Fixed

saqc/funcs/resampling.py

@@ -337,7 +337,7 @@ class ResamplingMixin:
         freq: str | None = None,
         drop: bool = False,
         squeeze: bool = False,
-        overwrite: bool = True,
+        overwrite: bool = False,
         **kwargs,
     ) -> "SaQC":
         """
@@ -395,7 +395,7 @@ class ResamplingMixin:
             If set to `True`, the appended flags frame will be squeezed - resulting in function specific flags informations
             getting lost.
 
-        overwrite: bool, default True
+        overwrite: bool, default False
             If set to True, the newly appended flags will overwrite exsiting flags. This might result in a loss of previous
             flagging information.
 
@@ -471,6 +471,7 @@ class ResamplingMixin:
                     "freq": freq,
                     "drop": drop,
                     "squeeze": squeeze,
+                    "overwrite": overwrite,
                     **kwargs,
                 },
             }

tests/funcs/test_functions.py

@@ -101,7 +101,9 @@ def test_flagSesonalRange(data, field):
             flag=BAD,
         )
         qc = qc.flagRange(newfield, min=test["min"], max=test["max"], flag=BAD)
-        qc = qc.concatFlags(newfield, method="match", target=field, flag=BAD)
+        qc = qc.concatFlags(
+            newfield, method="match", target=field, flag=BAD, overwrite=True
+        )
         qc = qc.dropField(newfield)
         flagged = qc._flags[field] > UNFLAGGED
         assert flagged.sum() == expected