Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
SaQC
Manage
Activity
Members
Labels
Plan
Issues
35
Issue boards
Milestones
Wiki
Code
Merge requests
8
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
rdm-software
SaQC
Commits
19725041
Commit
19725041
authored
5 years ago
by
David Schäfer
Browse files
Options
Downloads
Patches
Plain Diff
bugfix: variables not listed on the left hand side in the config
were not available in flagger based dsl function (e.g. isflagged)
parent
6c729138
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
saqc/core/core.py
+1
-1
1 addition, 1 deletion
saqc/core/core.py
test/core/test_core.py
+0
-17
0 additions, 17 deletions
test/core/test_core.py
with
1 addition
and
18 deletions
saqc/core/core.py
+
1
−
1
View file @
19725041
...
...
@@ -18,7 +18,7 @@ def _collectVariables(meta, data):
find every relevant variable
"""
# NOTE: get to know every variable from meta
variables
=
[]
variables
=
list
(
data
.
columns
)
for
idx
,
configrow
in
meta
.
iterrows
():
varname
=
configrow
[
Fields
.
VARNAME
]
# assign = configrow[Fields.ASSIGN]
...
...
This diff is collapsed.
Click to expand it.
test/core/test_core.py
+
0
−
17
View file @
19725041
...
...
@@ -98,23 +98,6 @@ def test_positionalPartitioning(data, flagger, flags):
),
f
"
different end indices:
{
fchunk
.
index
.
max
()
}
vs.
{
end_index
}
"
@pytest.mark.parametrize
(
"
flagger
"
,
TESTFLAGGER
)
@pytest.mark.parametrize
(
"
optional
"
,
OPTIONAL
)
def
test_missingConfig
(
data
,
flagger
,
flags
):
"""
Test if variables available in the dataset but not the config
are handled correctly, i.e. are ignored
"""
var1
,
var2
,
*
_
=
data
.
columns
metadict
=
[{
F
.
VARNAME
:
var1
,
F
.
TESTS
:
"
flagAll()
"
}]
metafobj
,
meta
=
initMetaDict
(
metadict
,
data
)
pdata
,
pflagger
=
run
(
metafobj
,
flagger
,
data
,
flags
=
flags
)
assert
var1
in
pdata
and
var2
not
in
pflagger
.
getFlags
()
@pytest.mark.parametrize
(
"
flagger
"
,
TESTFLAGGER
)
def
test_errorHandling
(
data
,
flagger
):
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment