Skip to content
Snippets Groups Projects
Commit 26afce20 authored by Peter Lünenschloß's avatar Peter Lünenschloß
Browse files

unused KW-warning removed

parent 23e6f6b3
No related branches found
No related tags found
2 merge requests!370Release 2.0,!341unused KW-warning removed
......@@ -266,11 +266,6 @@ class SaQC(FunctionsMixin):
assert data.columns.difference(flags.columns).empty
data, flags = function(data=data, flags=flags, field=field, *args, **kwargs)
# we check the passed function-kwargs after the actual call,
# because now "hard" errors would already have been raised
# (eg. `TypeError: got multiple values for argument 'data'`,
# when the user pass data=...)
_warnForUnusedKwargs(function, kwargs, self._translator)
planned = self.called + [(field, (function, args, kwargs))]
......@@ -305,38 +300,3 @@ class SaQC(FunctionsMixin):
def __deepcopy__(self, memodict=None):
return self.copy(deep=True)
def _warnForUnusedKwargs(func, keywords, translator: Translator):
"""Warn for unused kwargs, passed to a SaQC.function.
Parameters
----------
func: SaqcFunction
Saqc internal data structure that hold all function info.
Returns
-------
None
Notes
-----
A single warning is thrown, if any number of missing kws are detected,
naming each missing kw.
"""
sig_kws = inspect.signature(func).parameters
# we need to ignore kws that are injected or by default hidden in ``**kwargs``
ignore = ("to_mask",)
missing = []
for kw in keywords:
# there is no need to check for
# `kw in [KEYWORD_ONLY, VAR_KEYWORD or POSITIONAL_OR_KEYWORD]`
# because this would have raised an error beforehand.
if kw not in sig_kws and kw not in ignore and kw not in translator.ARGUMENTS:
missing.append(kw)
if missing:
missing = ", ".join(missing)
warnings.warn(f"Unused argument(s): {missing}")
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment