Skip to content
Snippets Groups Projects
Commit 7092bde5 authored by Bert Palm's avatar Bert Palm 🎇
Browse files

Merge branch 'roller-check' into 'develop'

Check validity of CustomRoller Input

See merge request !644
parents b782b396 ed2569ea
No related branches found
No related tags found
3 merge requests!685Release 2.4,!684Release 2.4,!644Check validity of CustomRoller Input
Pipeline #160212 passed with stages
in 9 minutes and 43 seconds
......@@ -10,7 +10,7 @@ import warnings
import numpy as np
import pandas as pd
from pandas.api.types import is_bool
from pandas.api.types import is_bool, is_datetime64_any_dtype
if pd.__version__ < "1.4":
import pandas.core.window.indexers as indexers
......@@ -171,6 +171,9 @@ class CustomRoller:
if not is_bool(forward):
raise ValueError("forward must be a boolean")
if isinstance(window, str) and not is_datetime64_any_dtype(obj.index):
raise ValueError("expected datetime index when using offset windows")
# only relevant for datetime-like windows
if expand is None:
if min_periods is None:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment