Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
SaQC
Manage
Activity
Members
Labels
Plan
Issues
35
Issue boards
Milestones
Wiki
Code
Merge requests
7
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
rdm-software
SaQC
Commits
8ee09ba4
Commit
8ee09ba4
authored
2 years ago
by
David Schäfer
Browse files
Options
Downloads
Patches
Plain Diff
fix dfilter default value handling to not break plot
parent
6fd68670
No related branches found
No related tags found
4 merge requests
!685
Release 2.4
,
!684
Release 2.4
,
!567
Release 2.2.1
,
!566
Release 2.2
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
saqc/core/register.py
+5
-6
5 additions, 6 deletions
saqc/core/register.py
with
5 additions
and
6 deletions
saqc/core/register.py
+
5
−
6
View file @
8ee09ba4
...
...
@@ -104,14 +104,13 @@ def _getDfilter(
"""
dfilter
=
kwargs
.
get
(
"
dfilter
"
)
if
dfilter
is
None
or
isinstance
(
dfilter
,
OptionalNone
):
# let's see, if the function has a
n
default value
# let's see, if the function has a default value
default
=
func_signature
.
parameters
.
get
(
"
dfilter
"
)
if
default
:
if
default
is
None
or
default
.
default
==
inspect
.
Signature
.
empty
:
default
=
FILTER_ALL
else
:
default
=
default
.
default
if
default
==
inspect
.
Signature
.
empty
:
# function did not define a positional dfilter argument
default
=
None
dfilter
=
translation_scheme
.
DFILTER_DEFAULT
or
default
dfilter
=
max
(
translation_scheme
.
DFILTER_DEFAULT
,
default
)
else
:
# try to translate dfilter
if
dfilter
not
in
{
FILTER_ALL
,
FILTER_NONE
,
translation_scheme
.
DFILTER_DEFAULT
}:
...
...
This diff is collapsed.
Click to expand it.
David Schäfer
@schaefed
mentioned in commit
684dc8a0
·
2 years ago
mentioned in commit
684dc8a0
mentioned in commit 684dc8a0515470d644fc85fee95d07661c8dd572
Toggle commit list
David Schäfer
@schaefed
mentioned in commit
8f7a90e4
·
1 year ago
mentioned in commit
8f7a90e4
mentioned in commit 8f7a90e4aed61c79a9dc8d67541a46beba0907e8
Toggle commit list
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment