Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
SaQC
Manage
Activity
Members
Labels
Plan
Issues
36
Issue boards
Milestones
Wiki
Code
Merge requests
8
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
rdm-software
SaQC
Commits
ccf2f228
Commit
ccf2f228
authored
2 years ago
by
Bert Palm
🎇
Browse files
Options
Downloads
Patches
Plain Diff
added slice support for Flags
parent
3e185be7
No related branches found
Branches containing commit
No related tags found
Tags containing commit
3 merge requests
!685
Release 2.4
,
!684
Release 2.4
,
!633
added slice support for Flags
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG.md
+1
-0
1 addition, 0 deletions
CHANGELOG.md
saqc/core/flags.py
+22
-2
22 additions, 2 deletions
saqc/core/flags.py
tests/core/test_flags.py
+48
-0
48 additions, 0 deletions
tests/core/test_flags.py
with
71 additions
and
2 deletions
CHANGELOG.md
+
1
−
0
View file @
ccf2f228
...
...
@@ -10,6 +10,7 @@ SPDX-License-Identifier: GPL-3.0-or-later
[
List of commits
](
https://git.ufz.de/rdm-software/saqc/-/compare/v2.3.0...develop
)
### Added
-
Methods
`logicalAnd`
and
`logicalOr`
-
`Flags`
supports slicing and column selection with
`list`
or a
`pd.Index`
.
### Changed
### Removed
### Fixed
...
...
This diff is collapsed.
Click to expand it.
saqc/core/flags.py
+
22
−
2
View file @
ccf2f228
...
...
@@ -320,8 +320,28 @@ class Flags:
# ----------------------------------------------------------------------
# item access
def
__getitem__
(
self
,
key
:
str
)
->
pd
.
Series
:
return
self
.
_data
[
key
].
squeeze
()
def
__getitem__
(
self
,
key
:
str
|
list
|
pd
.
Index
)
->
pd
.
Series
|
Flags
:
if
isinstance
(
key
,
str
):
return
self
.
_data
[
key
].
squeeze
()
if
isinstance
(
key
,
slice
):
key
=
self
.
columns
[
key
]
if
isinstance
(
key
,
(
list
,
pd
.
Index
)):
# only copy necessary data
data
=
self
.
_data
try
:
self
.
_data
=
{}
new
=
self
.
copy
()
finally
:
self
.
_data
=
data
new
.
_data
=
{
k
:
self
.
_data
[
k
].
copy
()
for
k
in
key
}
return
new
raise
TypeError
(
"
Key must be of type str, list or index of string or slice,
"
f
"
not
{
type
(
key
)
}
.
"
)
def
__setitem__
(
self
,
key
:
SelectT
,
value
:
ValueT
):
# force-KW is only internally available
...
...
This diff is collapsed.
Click to expand it.
tests/core/test_flags.py
+
48
−
0
View file @
ccf2f228
...
...
@@ -49,6 +49,7 @@ for d in _arrays:
def
is_equal
(
f1
,
f2
):
"""
assert Flags instance equals other
"""
assert
f1
.
columns
.
equals
(
f2
.
columns
)
for
c
in
f1
.
columns
:
assert
test_hist
.
is_equal
(
f1
.
history
[
c
],
f2
.
history
[
c
])
...
...
@@ -334,3 +335,50 @@ def test_columns_setter_raises(columns, err):
)
with
pytest
.
raises
(
err
):
flags
.
columns
=
columns
@pytest.mark.parametrize
(
"
data,key,expected
"
,
[
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
"
a
"
,
pd
.
Series
([
0
,
1
],
dtype
=
float
)),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
"
b
"
,
pd
.
Series
([],
dtype
=
float
)),
],
)
def
test__getitem__scalar
(
data
,
key
,
expected
):
flags
=
Flags
({
k
:
pd
.
Series
(
v
,
dtype
=
float
)
for
k
,
v
in
data
.
items
()})
result
:
pd
.
Series
=
flags
[
key
]
assert
isinstance
(
result
,
pd
.
Series
)
assert
result
.
equals
(
expected
)
# assert copying
assert
flags
[
key
]
is
not
flags
[
key
]
@pytest.mark.parametrize
(
"
data,key,expected
"
,
[
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
[],
dict
()),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
[
"
a
"
],
dict
(
a
=
[
0
,
1
])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
[
"
a
"
,
"
b
"
],
dict
(
a
=
[
0
,
1
],
b
=
[])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
pd
.
Index
([]),
dict
()),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
pd
.
Index
([
"
a
"
]),
dict
(
a
=
[
0
,
1
])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
pd
.
Index
([
"
a
"
,
"
b
"
]),
dict
(
a
=
[
0
,
1
],
b
=
[])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
slice
(
None
),
dict
(
a
=
[
0
,
1
],
b
=
[])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
slice
(
0
,
1
),
dict
(
a
=
[
0
,
1
])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
slice
(
1
,
99
),
dict
(
b
=
[])),
(
dict
(
a
=
[
0
,
1
],
b
=
[]),
slice
(
5
,
99
),
dict
()),
],
)
def
test__getitem__listlike_and_slice
(
data
,
key
,
expected
):
flags
=
Flags
({
k
:
pd
.
Series
(
v
,
dtype
=
float
)
for
k
,
v
in
data
.
items
()})
result
:
Flags
=
flags
[
key
]
assert
isinstance
(
result
,
Flags
)
# assert that a new Flags object was created
assert
flags
[
key
]
is
not
flags
[
key
]
# assert that internal data is copied
if
len
(
result
):
left
=
result
.
_data
[
result
.
columns
[
0
]]
right
=
flags
.
_data
[
result
.
columns
[
0
]]
assert
left
is
not
right
expected
=
Flags
({
k
:
pd
.
Series
(
v
,
dtype
=
float
)
for
k
,
v
in
expected
.
items
()})
is_equal
(
result
,
expected
)
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment