Typehints
The following discussion from !293 (merged) should be addressed:
-
@luenensc started a discussion: (+4 comments) Hey by breifly looking over the changes, i noticed you didnt stick to our documentation policy when changing the docstrings.
For example, you added
window : str, tuple of string
and else where, it is without commata:
min_periods : int or tuple of int
Please be consistent here. Also, We kind of overcame once, to have it the following numpy-ish way, i think:
min_periods : {int, tuple[int]}
Hate to be so pedantic, its just, that the docstring looks confusing/ugly, when the format changes from entry to entry and i kind of invested some care to keep it unitary - so would be nice we sticked to it.
(Also if you favor another policy, we can talk about it - i have no hard priorities - but since we have one in place, lets stick to it.)