DmpFlagger: remove git dependency
2 unresolved threads
2 unresolved threads
Closing #121 (closed)
Merge request reports
Activity
Filter activity
added cleanup/refactoring + 1 deleted label
36 36 def __init__(self, dtype): 37 37 # NOTE: the type of the _flags DictOfSeries 38 38 self.dtype = dtype 39 self.extra_defaults = dict() -
this is crucial eg. for something like this:
flagscol, extras = flagger.getFlags(field, full=True) for key, ser in extras.items(): fill_val = flagger.extra_defaults[key] extras[key] = shift2Freq(ser, method, freq, fill_value=fill_val)also for simply resetting (deleting) any number of rows from a extra-field we need to know what to fill the holes with..
Edited by Bert Palm -
it is theoretically important and currently dead code and need to stay if we want to support
extra-stuff.Edited by Bert Palm -
and it has nothing to do with remove git dependency at all ;) so just let it life.
Edited by Bert Palm changed this line in version 2 of the diff
-
Edited by Bert Palm
36 35 37 36 38 37 class DmpFlagger(CategoricalFlagger): 39 def __init__(self, include_version=True): 38 def __init__(self, **kwargs): 40 39 super().__init__(FLAGS) 41 40 self.flags_fields = [FlagFields.FLAG, FlagFields.CAUSE, FlagFields.COMMENT] 42 self.extra_defaults = dict(cause=FLAGS[0], comment="") changed this line in version 2 of the diff
mentioned in commit cc3c0e6e
