Modularization of the test functions
Compare changes
Files
48+ 6
− 6
This Merge Request is rather large, I therefore like to see two approvals. I won't assign anyone personally, because I guess, the review work is best split. I think it would be beneficial, if:
saqc.core
. The design is not particularly beautiful, maybe I missed something.saqc.funcs
. I mainly added type hints there, but also made a few changes, when I or the type checker saw fit.SaQC
.
This Merge Request incorporates all changes made in !205 (closed), and therefor should be merged after !205 (closed)
The basic architecture is rather simplistic and is based on a lot of repetition. Not ideal, I know, but this was the only way, I could figure out, to get code completions in rather simplistic editing environments working. With the release of Python 3.10 (especially this feature and it's likely backport) in october, we should be able to remove the duplication of function signatures again.
core
submodule named modules
saqc.core.modules
, there is a new file for every file in saqc.funcs
:
saqc.funcs
data
and flagger
are removedModuleBase
class defined in saqc.core.modules.base
, which mainly takes care of the redirection of function callsFuncModules
in saqc.core.modules.__init__
stitches all test function modules together. Its main purpose is to not clutter saqc.core.core.SaQC
by too many repetitive attribute assignmentssaqc.funcs
. Seperating this into multiple MRs would have been the nicer approach, but I wanted to get modularization done, without further delays