Skip to content
Snippets Groups Projects

Several fixes

Closed David Schäfer requested to merge multifix into develop
1 unresolved thread

A container branch for the fixes of several issues I encountered while rolling out the current SaQC on the SEEFO pipeline.

Not sure, if this needs a real review, but as some of the changes touched code I am not completely familiar with, maybe you, @palmb and @luenensc want to have a look anyhow?

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bert Palm
  • 78 78 hist = hist.copy()
    79 79 mask = mask.copy()
    80 80
    81 self.hist = hist
    81 self.hist = hist.astype("category")
  • So maybe one more general remark about the somewhat random collections of commits within in this MR:

    All changes are fixes to issues I had when porting the SEEFO-pipeline to the latest develop (through !260 (merged)). Every commit is a fix to one issue I encountered (I tried hard to not intermingle changes) in chronological order. With exception of 1da172e8, which corrects faulty behavior without breakage, all changes fix an issue hardly breaking the formerly running pipeline. So, I had to come up with some sort of solutions to the underlying problems in order to get things into their former state of working. Are the proposed changed the only solution to the underlying problems? Likely not! Are these changed the best solution to the underlying problems? Probably also not...

    Not sure, if this comments helps or not, I just wanted to make clear, that there are no simple refactorings incorporated. I chose the commit message prefix [FIX] as, from the point of view of the SEEFO-pipeline, these changes are fixing regressions.

    With that out of the way, I am happy to discuss any objections/suggestions on any suitable channel. Cheers!

  • David Schäfer added 1 commit

    added 1 commit

    • 686065dc - [FIX] reduce the memory consumption of SaQC by >50% through Histories of type pd.Categorical

    Compare with previous version

  • David Schäfer mentioned in merge request !260 (merged)

    mentioned in merge request !260 (merged)

  • Closing as all commits, will go in through !260 (merged)

  • Please register or sign in to reply
    Loading