Skip to content
Snippets Groups Projects

fixed some plotting issues

Merged Bert Palm requested to merge plottingFollowup into develop
1 unresolved thread
  • removed dicts as default kw-params, as this can have unexpected side-effects
  • added plt.show() in interactive mode -> make the figure window come up
  • use the right backend in none-interactive mode. problems arise if i call interactive after a non-interactive plot call..
  • updated signature in core.modules.tools.plot
Edited by Bert Palm

Merge request reports

Pipeline #28968 passed

Pipeline passed for 472062b5 on plottingFollowup

Test coverage 74.00% from 1 job

Merged by Bert PalmBert Palm 3 years ago (Jun 17, 2021 1:31pm UTC)

Loading

Pipeline #29437 passed

Pipeline passed for e97b634e on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 335 359 stats=stats,
    336 360 plot_kwargs=plot_kwargs,
    337 361 fig_kwargs=fig_kwargs,
    338 362 stats_dict=stats_dict,
    339 363 )
    340 pickle = save_kwargs.pop("pickle", False)
    341 if save_path:
    342 if pickle:
    364
    365 if interactive:
    366 plt.show()
    367
    368 else:
    369 if save_kwargs.pop("pickle", False):
    343 370 with open(save_path, "wb") as f:
    344 371 pickle.dump(fig, f)
  • David Schäfer
  • Bert Palm added 1 commit

    added 1 commit

    • 8be790fe - removed default fixed figure-size in interactive mode, which is unfortunately on small displays

    Compare with previous version

  • Bert Palm added 1 commit

    added 1 commit

    • 472062b5 - removed default fixed figure-size in interactive mode, which is unfortunate on small displays

    Compare with previous version

  • David Schäfer resolved all threads

    resolved all threads

  • David Schäfer approved this merge request

    approved this merge request

  • merged

  • Bert Palm mentioned in commit e97b634e

    mentioned in commit e97b634e

  • Please register or sign in to reply
    Loading