Skip to content
Snippets Groups Projects

no more unflagged column

Closed Bert Palm requested to merge NoMoreUnflaggedColumn into develop
All threads resolved!
  • i removed the unflagged column at all.
  • now History() takes a mandatory index at creation an nothing more.
  • to create a History from data (hist-df, mask-df, and meta list) one can call createHistory(..)
  • History.max() still return UNFLAGGED, even for empty Histories, which is possible now because of the inital passed index

only this commit - !285 (73708889) is relevant, the rest comes from historymeta (!284 (merged) )

i dont know where the translator rely on the UNFLAGGED-column, but this we need to adjust, i guess..

i also dont know if we want to go down the line, but i would say we have to decide which way we want to go:

  • a) without UNFLAGGED-column with quite simple history-creation, (mandatory index to __init__)
  • b) with UNFLAGGED-column, more complex History creation (hist, mask, meta are needed), except passing no args at all (empty History)
Edited by Bert Palm

Merge request reports

Pipeline #29950 failed

Pipeline failed for 9190ef91 on NoMoreUnflaggedColumn

Test coverage 71.00% from 1 job
Approval is optional

Closed by Bert PalmBert Palm 3 years ago (Jun 28, 2021 3:26pm UTC)

Merge details

  • The changes were not merged into develop.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Schäfer
    • Resolved by David Schäfer

      Now, that I arranged myself, with the initial column, you wan't to steal from me again ?

      Just kidding, if this works out, I am in favor of the change. But TBH, I currently don't really oversee all the moving parts, that might be affected by this.

  • Bert Palm added 1 commit

    added 1 commit

    Compare with previous version

  • Bert Palm added 1 commit

    added 1 commit

    • 9190ef91 - fixed docu, and minor leftovers

    Compare with previous version

  • David Schäfer resolved all threads

    resolved all threads

  • David Schäfer resolved all threads

    resolved all threads

  • David Schäfer approved this merge request

    approved this merge request

  • Bert Palm changed title from WIP no more unflagged column to no more unflagged column

    changed title from WIP no more unflagged column to no more unflagged column

  • Author Owner

    merged in !284 (merged)

  • closed

  • Please register or sign in to reply
    Loading