no more unflagged column
- i removed the unflagged column at all.
- now
History()
takes a mandatoryindex
at creation an nothing more. - to create a History from data (hist-df, mask-df, and meta list) one can call
createHistory(..)
-
History.max()
still returnUNFLAGGED
, even for empty Histories, which is possible now because of the inital passedindex
only this commit - !285 (73708889) is relevant, the rest comes from historymeta (!284 (merged) )
i dont know where the translator rely on the UNFLAGGED-column, but this we need to adjust, i guess..
i also dont know if we want to go down the line, but i would say we have to decide which way we want to go:
- a) without UNFLAGGED-column with quite simple history-creation, (mandatory index to
__init__
) - b) with UNFLAGGED-column, more complex History creation (hist, mask, meta are needed), except passing no args at all (empty History)
Merge request reports
Activity
requested review from @schaefed
added cleanup/refactoring internal architecture + 1 deleted label
mentioned in merge request !284 (merged)
assigned to @palmb
- Resolved by Bert Palm
- Resolved by David Schäfer
- Resolved by David Schäfer
Now, that I arranged myself, with the initial column, you wan't to steal from me again ?
Just kidding, if this works out, I am in favor of the change. But TBH, I currently don't really oversee all the moving parts, that might be affected by this.
- Resolved by David Schäfer
so you approve ? then i merge it back to !284 (merged)
merged in !284 (merged)