Skip to content
Snippets Groups Projects

remove History.mask to fix masking="none" issues

Merged David Schäfer requested to merge nomask into develop

This MR removes the mask as decided in #199 (closed) and fixes #222 (closed).

The removal of the mask makes functions annotated with masking="none" and masking="field" consistent. With this MR in place, there is (most likely) no need to change a function body, when the function annotation is changed from "none" to "field" (and the other way round) and opens up the possibility to dismiss the clearance of flags between function calls (an implementation draft can be found here). Especially the last point seems very appealing to me as this would reduce code, but more so conceptual (accidental ?) complexity of the system.

Edited by David Schäfer

Merge request reports

Pipeline #39106 passed

Pipeline passed for 8d446abc on nomask

Test coverage 75.00% from 1 job
Approved by

Merged by David SchäferDavid Schäfer 3 years ago (Aug 31, 2021 12:27pm UTC)

Pipeline #39231 passed

Pipeline passed for 1f1a4d5b on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading