Skip to content
Snippets Groups Projects

Oddwater od implementation

Merged Peter Lünenschloß requested to merge oddwater_OD_implementation into develop
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
34 35 "roc": ts_ops.rateOfChange,
35 36 "scale": ts_ops.scale,
36 37 "normScale": ts_ops.normScale,
38 "stdByMean": ts_ops.standardizeByMean,
  • 12 12 spikes_flagSlidingZscore,
    13 13 spikes_flagBasic,
    14 14 spikes_flagRaise,
    15 spikes_flagOddWater,
    15 spikes_flagMultivariateKNNScores
    • A rather lengthy new test name...

      Do we have a documentation for the function? Is it also updated after the name change?

    • no dokumentation yet.

      dokumentation is on the way.

      just wanted to merge some tiny features (but failed handling this nasty dios submodule)

      Yes! the name is really lengthy. but since we have "SlidingZScore" as well, i thought, having composita of three parts is still ok.

      More concise naming i would like as well - but i couldnt think of a non cryptic/propper shorter name. Any suggestions?

      More generally spoken - i was not sure which policy we should aim for:

      1. having short/abbreviated/concise names at the cost of readabillity and intuitive conmprehensibillity, or

      2. more verbose but informative names, at the cost of compactness.

      Turns out its not so easy to keep the balance from case to case and stay consistent/corporate. I tend to verbosity and informativeness - but have the intuition you, @palmb and @schaefed prefer concise/compact naming?

    • Please register or sign in to reply
  • added 2 commits

    Compare with previous version

  • mentioned in commit 379eb7b9

  • Please register or sign in to reply
    Loading