Make more functions source-target ready
I adapted the follwing handles_target=True
functions:
funcs.outliers.flagMVScores
-
funcs.outliers.flagCrossStatistic
(which should actually be namedflagCrossStatistics
, right?) funcs.drift.flagDriftFromReference
These functions are not covered by the general source-target workflow, so I implemented the following behavior:
-
assert len(field) == len(target)
as all of these functions seem to modify all given fields - drop existing
target
s - copy all fields to there respective targets with
copyField
(i.e. we preserve histories)
I hope I didn't mess up, the general functionality, but I guess a critical review would be good @luenensc .
Merge request reports
Activity
assigned to @schaefed
added 38 commits
-
3e32754b...41aefda4 - 34 commits from branch
develop
- 0b8985cb - rename test
- 65b8c574 - fixed imports
- 5cce9ced - Merge branch 'develop' into mo-targets
- 446b731a - added some function writing documentation
Toggle commit list-
3e32754b...41aefda4 - 34 commits from branch
requested review from @luenensc
I went over the changes and think, everything is fine.
funcs.outliers.flagCrossStatistic
(which should actually be namedflagCrossStatistics
, > right?)Yes i think so. Also, mabe, we should change wording from cross to row - because thats what is happening, row-wise scoring and flagging. But i guess thats not a renaming MR.
added 18 commits
-
7728f0b4...7a15bb35 - 12 commits from branch
develop
- 2f12d5ac - add compatability check
- 233bbaaf - rename function flagCrossStatitic -> flagCrossStatitics
- de2434c0 - implement a generalized multi variate source-target workflow
- 2e96277c - remove function flagDriftFromScaledNorm
- 71eedcce - Merge branch 'develop' into mo-targets
- 7de7a492 - simplified functions
Toggle commit list-
7728f0b4...7a15bb35 - 12 commits from branch
added 14 commits
-
7de7a492...b09e93f4 - 12 commits from branch
develop
- 9f663d6f - remove unnecessary restriction
- 060ac5b3 - Merge branch 'develop' into mo-targets
-
7de7a492...b09e93f4 - 12 commits from branch
changed milestone to %2.0.1
mentioned in commit 76ce086a
mentioned in issue #279 (closed)
mentioned in commit 63b55c6d
mentioned in commit 684dc8a0
mentioned in commit 8f7a90e4