Skip to content
Snippets Groups Projects

Make more functions source-target ready

Merged David Schäfer requested to merge mo-targets into develop

I adapted the follwing handles_target=True functions:

  • funcs.outliers.flagMVScores
  • funcs.outliers.flagCrossStatistic (which should actually be named flagCrossStatistics, right?)
  • funcs.drift.flagDriftFromReference

These functions are not covered by the general source-target workflow, so I implemented the following behavior:

  • assert len(field) == len(target) as all of these functions seem to modify all given fields
  • drop existing targets
  • copy all fields to there respective targets with copyField (i.e. we preserve histories)

I hope I didn't mess up, the general functionality, but I guess a critical review would be good @luenensc .

Edited by David Schäfer

Merge request reports

Pipeline #56507 passed

Pipeline passed for 060ac5b3 on mo-targets

Test coverage 74.00% (0.00%) from 1 job
Approved by

Merged by David SchäferDavid Schäfer 3 years ago (Dec 10, 2021 1:37pm UTC)

Pipeline #56508 passed

Pipeline passed for 76ce086a on develop

Test coverage 74.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading