`flagByStatLowPass` is overwriting existing flags
All threads resolved!
All threads resolved!
The function flagByStatLowPass
works by checking a certain condition window wise. If a certain conditions is met, the entire window is flagged, which might overwrite exiting flags. This MR fixes this unintended behavior.
Merge request reports
Activity
Filter activity
changed milestone to %2.3.0
requested review from @palmb
assigned to @schaefed
- Resolved by David Schäfer
overwriting existing flags is allowed. i don't see a reason for the MR. Also the input data is masked correctly, so IMO, to prevent the function to set certain flags, based on historical data, should not be forbidden.
Edited by Bert Palm
removed milestone %2.3.0
mentioned in issue #404 (closed)
added 98 commits
-
b57ec1c5...a4d4021a - 96 commits from branch
develop
- 0e53a174 - Merge branch 'develop' into fix_noise
- 44b468cd - isorting
-
b57ec1c5...a4d4021a - 96 commits from branch
mentioned in commit c824a270
mentioned in issue #410 (closed)
Please register or sign in to reply