Skip to content
Snippets Groups Projects

Draft: Slicing Support

Closed David Schäfer requested to merge get_set_item into develop
2 unresolved threads

Addresses #368 (closed)

Merge request reports

Pipeline #146941 failed

Pipeline failed for 5c2fef21 on get_set_item

Test coverage 77.00% (0.00%) from 1 job
Approval is optional
Test summary results are loading

Closed by David SchäferDavid Schäfer 1 year ago (Sep 5, 2023 6:00pm UTC)

Merge details

  • The changes were not merged into .

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
126 126 raise AttributeError(f"SaQC has no attribute {repr(key)}")
127 127 return partial(FUNC_MAP[key], self)
128 128
129 def __getitem__(self, key: str | Sequence[str] | slice) -> SaQC:
130
131 if isinstance(key, slice):
132 key = self._data.columns.to_list()
133 keys = toSequence(key)
134
135 return self._construct(_data=self._data[keys], _flags=self._flags.select(keys))
136
137 def __setitem__(self, key: str | Sequence[str] | slice, obj: SaQC) -> None:
138
139 if isinstance(key, slice):
140 key = self._data.columns.to_list()
  • 137 def __setitem__(self, key: str | Sequence[str] | slice, obj: SaQC) -> None:
    138
    139 if isinstance(key, slice):
    140 key = self._data.columns.to_list()
    141
    142 lkeys = toSequence(key)
    143 rkeys = obj._data.columns
    144 if len(lkeys) != len(rkeys):
    145 raise ValueError(
    146 f"cannot set value object with {len(rkeys)} fields to indexing result of {len(lkeys)} fields"
    147 )
    148
    149 for lkey, rkey in zip(lkeys, rkeys):
    150 self._data[lkey] = obj._data[rkey]
    151 self._flags[lkey] = obj._flags[rkey]
    152 self._flags.history[lkey] = obj._flags.history[rkey]
  • David Schäfer added 3 commits

    added 3 commits

    Compare with previous version

  • David Schäfer added 6 commits

    added 6 commits

    Compare with previous version

  • David Schäfer added 2 commits

    added 2 commits

    Compare with previous version

  • David Schäfer added 1 commit
  • David Schäfer added 1 commit

    added 1 commit

    Compare with previous version

  • David Schäfer added 1 commit
  • David Schäfer changed milestone to %2.5.0

    changed milestone to %2.5.0

  • closed

  • Please register or sign in to reply
    Loading