Skip to content
Snippets Groups Projects

introduced new DictOfSeries

Merged introduced new DictOfSeries
dios_replace into develop
Merged Bert Palm requested to merge dios_replace into develop

if i refer to DictOfSeries i always mean the new one.

should be merged after !628 (merged) to keep things seperated

⚠ only doc-test fail all tests succeed

Code

added:

  • new saqc.frame.DictOfSeries class
  • DictOfSeries.__eq__ return a scalar boolean (not a bool frame or object like pandas do)
  • DictOfSeries keys can be of type str, int or float (needs discussion )
  • new function _castGenericResult in saqc.funcs.generic.py
  • new method Flags.keys()

changed:

  • SaQC._initData
  • generic handling
  • rm access to pd.Series.name where the code relied on that the old-DictOfSeries set the name while taking it in

removed:

  • rm dios package
  • to_dios
  • mergeDios
  • concatDios
  • Flags.toDios()

tests

added:

  • test_SaQC_attributes

removed:

  • test_concatDios
  • test_concatDios_warnings

fixed:

  • test_core.core.test_copy
  • rm some old calls to .squeeze()
  • commented old code in fuzzy.lib.functionKwargs that used FreqString, ColumnName, IntegerWindow, which are non-existent

(pre-existing) BUG s

  • in test_masking.py: test_maskingMasksData() see change and comment
Edited by Bert Palm

Merge request reports

Pipeline #152790 passed

Stage: compliance
    Stage: test
      Stage: build

        Pipeline passed for 7986eea6 on dios_replace

        Test coverage 77.00% (0.00%) from 1 job
        Approval is optional

        Merged by Bert PalmBert Palm 2 years ago (Feb 27, 2023 10:20am UTC)

        Merge details

        • Changes merged into with 3e185be7.
        • Deleted the source branch.

        Pipeline #153997 passed

        Stage: compliance
          Stage: test
            Stage: build

              Pipeline passed for 3e185be7 on develop

              Test coverage 77.00% (0.00%) from 1 job

              Activity

              Filter activity
              • Approvals
              • Assignees & reviewers
              • Comments (from bots)
              • Comments (from users)
              • Commits & branches
              • Edits
              • Labels
              • Lock status
              • Mentions
              • Merge request status
              • Tracking
              Please register or sign in to reply