Skip to content
Snippets Groups Projects

Handle different start and end times of components

Merged Martin Lange requested to merge start-times into main
  • connect and _connect get an argument start_time that is to be passed to try_connect instead of self.time
  • Connect helper pushes data twice: once for start_time and once for info.time (if it is not equal to start_time)
  • Starting time can be passed to component's run(), and is auto-determined if not provided

Basically, only the changes in interfaces.py, schedule.py, component.py and connect_helper.py are of interest. The rest is fixes for the breaking change to the interface.

Fixes #4 (closed)

Edited by Martin Lange

Merge request reports

Pipeline #132220 passed

Pipeline passed for dc878a77 on start-times

Test coverage 97.00% (0.00%) from 1 job
Approval is optional

Merged by Martin LangeMartin Lange 2 years ago (Nov 28, 2022 10:33am UTC)

Pipeline #132221 passed

Pipeline passed for 4aa2c412 on main

Test coverage 97.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in merge request finam-netcdf!32 (merged)

  • Martin Lange mentioned in merge request finam-plot!32 (merged)

    mentioned in merge request finam-plot!32 (merged)

  • Martin Lange added 1 commit

    added 1 commit

    • 4aae0d3e - fix handling of static inputs in connectors, check output info times

    Compare with previous version

  • Martin Lange added 1 commit

    added 1 commit

    • 6f8a20ec - fix handling of time and static inputs in connectors, check output info times

    Compare with previous version

  • Martin Lange added 17 commits

    added 17 commits

    • 6f8a20ec...b4d878ed - 6 commits from branch main
    • 1fae570b - add start time as argument in connect methods, push twice in connector
    • 389cbd85 - fix components and their tests
    • 8ee1ea6f - the scheduler tries to determine the minimum starting time of components
    • 28c65e00 - fix the remaining tests
    • 20b400e7 - fix component time getter to allow no time before connect phase
    • b210c07c - tweak initial double push in connect helper
    • 844e3a2e - add a test for unaligned starting times
    • b930ed11 - update docstrings for new time arguments
    • 5bc8f0ee - make time in try_connect mandatory
    • 53ebe64a - fix docs and doctests
    • 8eaa8aa2 - fix handling of time and static inputs in connectors, check output info times

    Compare with previous version

  • Martin Lange added 18 commits

    added 18 commits

    • 8eaa8aa2...3361aaf8 - 7 commits from branch main
    • 5a68d566 - add start time as argument in connect methods, push twice in connector
    • 894635c7 - fix components and their tests
    • 226492e9 - the scheduler tries to determine the minimum starting time of components
    • 3dfb8b71 - fix the remaining tests
    • b4253b8b - fix component time getter to allow no time before connect phase
    • 5b0638cb - tweak initial double push in connect helper
    • 3a34d88f - add a test for unaligned starting times
    • 46f89106 - update docstrings for new time arguments
    • 3e005ae9 - make time in try_connect mandatory
    • 4dda112e - fix docs and doctests
    • 13015860 - fix handling of time and static inputs in connectors, check output info times

    Compare with previous version

  • Martin Lange added 1 commit

    added 1 commit

    • 9b829e74 - fix regridding benchmarks for interface changes

    Compare with previous version

  • Sebastian Müller
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading